[mythtv] [PATCH] Internal DataDirect grabber functionality REVISEDVERSION USE THIS ONE!
ijr at po.cwru.edu
Mon Apr 19 01:13:52 EDT 2004
On Sunday 18 April 2004 08:54 pm, David Shay wrote:
> On Sunday 18 April 2004 07:50 pm, Isaac Richards wrote:
> > Yup, and I wasn't sure if I was going to get something into CVS this
> > soon, but I spent a good 5 or 6 hours last night fixing everything up so
> > it could go in.
> Appreciate all of the effort. In the future, should cursors be avoided?
Yes. When you're modifying code in a large existing project, care should be
taken to make your new code feel the same as the existing code. Cursors
aren't used anywhere else.
Also, using a non-random indentation style would have been appreciated.
Please look at the rest of what I changed as well (aside from moving stuff
around in videosource.cpp/.h).
It seems to me that the current parser is _very_ fragile
(DDStructureParser::characters(), for instance, looks rather easily broken to
me). There's a reason that Qt's DOM parser is used everywhere else in myth
-- I'd like to have this eventually switched over to that, but what's there
works for now.
> I noticed that the "dd-grab-all" flag and feature in mythfilldatabase is
> currently commented out. I have posed a question on the datadirect forum
> as to whether a full update every day would be considered acceptable use.
> They have plans to do "incremental updating" which would be ideal (and must
> be what Tivo uses...), but this is not out yet. If they respond that it is
> OK, could this be uncommented out?
I'd prefer not to have it enabled. For every 1,000 people using the grabber
(and using your quoted numbers of 2MB vs 300kb per day), that's, what, an
extra 50GB of completely unnecessary traffic for zap2it's servers per month?
More information about the mythtv-dev