[mythtv] [PATCH] HDTV Recorder Patch
ijr at case.edu
Thu Dec 2 00:57:46 UTC 2004
On Wednesday 01 December 2004 07:21 pm, Daniel Thor Kristjansson wrote:
> On Tue, 30 Nov 2004, Doug Larrick wrote:
> ]Sure sounds like it's not detecting keyframes properly. You might want to
> try ]my tsdump utility on a failing recording
> <http://jekyl.no-ip.org/doug/tsdump.C> ]and see if that program sees GOP or
> picture start.
> The recordings from PBS do not have GOP's, just picture starts. I'm
> testing a fallback to update the position map anyway. But I'm not
> sure why it's even recording this. I think maybe it's because we also
> pretend to have seen a GOP if we see 00 00 01 B3, the sequence header.
> Can we use the sequence headers instead of the GOP for the position map
Yeah, the old hdtvrecorder would treat sequence headers as gop starts if no
real gop headers were found. Looking over your patch, I think you've broken
else if (0xB8 == k1)
else if (0xB3 == k1 && !_gop_seen)
Which'll treat a sequence header as a gop a couple times, but HandleGOP will
set _gop_seen to true after a few calls, and not allow it to happen anymore.
More information about the mythtv-dev