[mythtv] Re: [PATCH] Add metadata editor to MythMusic

[Isaac Richards]

On Tuesday 28 December 2004 09:13 am, Paul wrote:
> > Isaac wrote:
> > >> The attached patch adds a metadata editor to MythMusic which
> > >> allows you to save the changes optionally to both the database and
> > >> the file. You access the editor from the playback screen by pressing
> > >> the INFO button. Useful if you notice the track that you are playing
> > >> has been wrongly tagged or the imported metadata is wrong.
> > >
> > >Are there images for this that weren't sent along with the patch?
> > >
> > >Isaac
>
> Just noticed a discrepancy in MythMusic's dbcheck.cpp which updates
> the database schema.
>
> At the top of the file currentDatabaseVersion is set to "1001" but at the
> bottom of the file there is an update from version "1001" to "1002".
>
> Shouldn't the currentDatabaseVersion not be set to "1002"?

It's really just there as a placeholder, so things don't conflict with mfd if 
someone else were to change the schema.

> If  I understand the code properly the update from version 1001 to 1002
> will never take place. If that is the case the above patch will not work
> because it uses the compilation field which is only available after the
> update to 1002.
>
> Not sure why my database already contains the update. Possibly it was
> updated
> by the mfd stuff?

Yup.

Isaac