[mythtv] [PATCH] deadlock when opening video input

Isaac Richards ijr at po.cwru.edu
Sun Jan 18 13:47:07 EST 2004


On Friday 16 January 2004 02:37 am, Kevin Hjelden wrote:
> This patch is to fix a deadlock when the video source is attempted to
> open and fails. tv_rec.cpp opens a thread to open the video source for
> recording, and then goes into an infinite loop waiting until the thread
> signals that the source is open. However, if the source fails to open,
> it simply returns (and doesn't retry) out of the thread causing the loop
> never to fail. This patch fixes that by having an error status in
> NuppelVideoRecoder that allows the function in tv_rec.cpp to abort if an
> error is thrown.
>
> I'm not the best linux coder, so hopefully this doesn't cause too many
> problems. I've had it successfully running on my myth box for a month or
> so with no noticable problems.

Certainly looks correct to me, I've just applied this.

Isaac


More information about the mythtv-dev mailing list