[mythtv] [PATCH] mythvideo cd support

[Xavier Hervy]

Xavier Hervy wrote:

> Xavier Hervy wrote:
> 
>> Hi Matt,
>> thanks for your help.
>>
>> Matt Porter wrote:
>>
>>> On Thu, Jul 01, 2004 at 11:09:55PM +0200, Xavier Hervy wrote:
>>>
>>>> I made a patch for media monitoring that allow MythDialog to 
>>>> intercept mediahandler before that mediamonitoring close 
>>>> activewindow and open the good plugin.
>>>
>>>
>>>
>>>
>>> <snip>
>>>
>>>> Actually it's work great in mythvideo.
>>>
>>>
>>>
>>>
>>> I agree, it works great when prompted to insert the media in the
>>> browser. Performing a context sensitive handler event is much nicer
>>> than blindly calling the handler again.
>>>
>>>
>>>> I also update my patch to remove some cout, i have forget to remove, 
>>>> fix  few little bug in videofilter.
>>>
>>>
>>>
>>>
>>> There's still some old code cruft in videoutils.cpp that's commented
>>> out, you should remove that (updatePlayWait).
>>
>>
>>
>> removed now.
>>
>>>
>>> I isolated the segfault I was seeing when cancelling the insertion
>>> request from the videobrowser. I've attached a patch for that
>>> versus your patchset, please consider including it.  Also, with
>>> onMediaEvent(), there's no need to have a Retry button, so I changed
>>> it to just focus on Cancel since onMediaEvent() will emit the
>>> retry signal when the user inserts the media.
>>
>>
>>
>> I have not removed Retry button because i'm thinking about people that 
>> don't use mediamonitoring. in fact, users who don't use mediamonitor 
>> can't use amovible storage then it was stupid. I removed it like you 
>> tell me.
>>
>>>
>>> I still have a segfault in videogallery, but I'm going to take a
>>> break and look at that in a bit.
>>
>>
>> Just to now, did you have a segfault too, when you go in Video Browser 
>> -> Video Filter or only in videogallery. it's to know if segfault come 
>> from videogallery or video filter.
>>
>> Xavier
>>
>>
> Last version of my patch and maybe the last (I hope)
> Xavier
> 
> 
Found a bug that i have made with mythvideo category, genre and country 
pathc the i fix it.

Xavier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialog_mediamonitoring.bz2
Type: application/octet-stream
Size: 1053 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040705/9fd71630/dialog_mediamonitoring-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythvideocdsupport.tar.bz2
Type: application/octet-stream
Size: 26005 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040705/9fd71630/mythvideocdsupport.tar-0001.obj