[mythtv] [PATCH] Fix parsing of FLAC tags in mythmusic

Curtis Stanford curtis at stanfordcomputing.com
Tue Jul 20 22:54:54 EDT 2004


I don't think mythmusic could have ever read FLAC tags correctly. Here is my 
patch:

Index: mythmusic/flacdecoder.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythmusic/mythmusic/flacdecoder.cpp,v
retrieving revision 1.16
diff -u -r1.16 flacdecoder.cpp
--- mythmusic/flacdecoder.cpp   25 May 2004 04:22:56 -0000      1.16
+++ mythmusic/flacdecoder.cpp   21 Jul 2004 02:53:09 -0000
@@ -465,8 +465,10 @@
     FLAC__ASSERT(0 != block);
     FLAC__ASSERT(block->type == FLAC__METADATA_TYPE_VORBIS_COMMENT);

+    title = getComment(block, "title");
     if (ignore_id3 || title.isEmpty())
     {
         getMetadataFromFilename(filename, QString(".flac$"), artist, album,
                                 title, genre, tracknum);
     }
@@ -474,7 +476,6 @@
     {
         artist = getComment(block, "artist");
         album = getComment(block, "album");
-        title = getComment(block, "title");
         genre = getComment(block, "genre");
         tracknum = getComment(block, "tracknumber").toInt();
         year = getComment(block, "date").toInt();


More information about the mythtv-dev mailing list