[mythtv] Little bug with MythWeather...[patch]

Bolton Emlyn (Nokia-TP-MSW/Vancouver) emlyn.bolton at nokia.com
Thu Jun 3 18:27:55 EDT 2004


I hope I got the diff right.

This should make mythweather pickup the exact location, rather than
matching the substring.

Patch attached for mythweather.cpp

Emlyn

-----Original Message-----
From: mythtv-dev-bounces at mythtv.org
[mailto:mythtv-dev-bounces at mythtv.org]On Behalf Of ext Matt Zimmerman
Sent: Thursday, June 03, 2004 10:19 AM
To: Development of mythtv
Subject: Re: [mythtv] Little bug with MythWeather...


On Wed, Jun 02, 2004 at 04:42:31PM -0700, Bolton Emlyn
(Nokia-TP-MSW/Vancouver) wrote:

> I'm happy to do a patch / fix, the three possible solutions I can see:
> 
> 1. Move the city data file around (least effort, least change)
> 2. Convert the data file to XML and use a parser
> 3. Prompt the user for the case when duplicates occur in the data
> 
> Any strong opinions on any of these solutions?

I prefer:

4. Tokenize the line first, and use the full city name for the
comparison
rather than using strstr() to search the whole line


-- 
 - mdz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: weather.cpp.patch
Type: text/x-patch
Size: 800 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040603/de61a227/weather.cpp.bin


More information about the mythtv-dev mailing list