[mythtv] [PATCH] Specify aspect ratio cycle

[Hamish Moffatt]

On Sun, Jun 06, 2004 at 08:38:38PM +1000, Hamish Moffatt wrote:
> On Thu, Jun 03, 2004 at 12:21:28AM +0200, Kristof Pelckmans wrote:
> > > Good idea. However I think you changed the default order, which violates
> > > the principle of least surprise. Currently it is:
> > >
> > >     kLetterbox_4_3 = 0,
> > >     kLetterbox_16_9,
> > >     kLetterbox_4_3_Zoom,
> > >     kLetterbox_16_9_Zoom,
> > >     kLetterbox_16_9_Stretch,
> > 
> > It was due to the standard behaviour of QMap : the items are sorted
> > alphabetically (by key) when iterating over the map.
> 
> I tried your patch and indeed now it uses the standard order for the
> modes. The only problem is that it doesn't take into account the
> default mode.

Sorry, I had another problem. The selected modes don't seem to be
correct. For example I set my modes to "16:9, 16:9 Zoom". What I get is:

1. Start in 16:9 (default for my source material),
2. Press W takes me to 16:9 (bug I reported already),
3. Press W again takes me to 4:3 (why?),
4. Press W again returns to 16:9 (ok).

Similarly if I set "16:9 Zoom, 16:9" I get 16:9, then 16:9 Zoom, then
4:3, then 16:9 Zoom, then 4:3 etc. Seems like the second mode is 4:3
regardless of what I actually set. I didn't try a set of three modes.


Hamish
-- 
Hamish Moffatt VK3SB <hamish at debian.org> <hamish at cloud.net.au>