[mythtv] [Patch] graboptions

David myth at dgreaves.com
Wed Jun 23 05:38:55 EDT 2004


This is my third try - maybe it will be lucky :D

There seems to be a bug with --graboptions.

If you use --graboptions it concatenates it to the source grabber
and then does a text comparison with the expected grabber names so it
will always fall through to:
...
else
{
isNorthAmerica = true;
command.sprintf("nice %s --days 1 --offset %d --config-file '%s' "
"--output %s", xmltv_grabber.ascii(),
offset, configfile.ascii(), filename.ascii());

I doubt this is intended

David

Changelog:
graboptions means: "additional options to pass to your configured
grabber prepended to the compiled in options"


-------------- next part --------------
Index: programs/mythfilldatabase/filldata.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythfilldatabase/filldata.cpp,v
retrieving revision 1.118
diff -u -r1.118 filldata.cpp
--- programs/mythfilldatabase/filldata.cpp	15 Jun 2004 02:11:01 -0000	1.118
+++ programs/mythfilldatabase/filldata.cpp	16 Jun 2004 07:27:58 -0000
@@ -2226,7 +2226,7 @@
 
 bool grabData(Source source, int offset, QDate *qCurrentDate = 0)
 {
-    QString xmltv_grabber = source.xmltvgrabber + graboptions;
+    QString xmltv_grabber = source.xmltvgrabber;
 
     if (xmltv_grabber == "datadirect")
         return grabDDData(source, offset, *qCurrentDate);
@@ -2323,6 +2323,7 @@
          xmltv_grabber == "tv_grab_jp"))
          command += " --quiet";
 
+    command+= graboptions;
 
     if (!quiet)
          cout << "----------------- Start of XMLTV output -----------------" << endl;
@@ -3038,7 +3039,7 @@
             cout << "   <xawtvrcfile> = file to read\n";
             cout << "\n";
             cout << "--graboptions <\"options\">\n";
-            cout << "   Pass options to grabber\n";
+            cout << "   additional options to pass to your configured grabber prepended to the compiled in options\n";
             cout << "\n";
             cout << "--refresh-today\n";
             cout << "--refresh-second\n";




More information about the mythtv-dev mailing list