[mythtv] [PATCH] Channel editor : visible setting (alternative)

Kevin Kuphal kevin.kuphal at myrealbox.com
Sat Mar 13 12:20:15 EST 2004


Did this ever get applied?

> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org 
> [mailto:mythtv-dev-bounces at mythtv.org] On Behalf Of John Pullan
> Sent: Thursday, March 04, 2004 4:38 PM
> To: Development of mythtv
> Subject: Re: [mythtv] [PATCH] Channel editor : visible 
> setting (alternative)
> 
> 
> Changed my mind, and did it a slightly different (tidier ?) way 
> Later
> 
> On Thu, 2004-03-04 at 17:18, John Pullan wrote:
> > So here's a patch which implements a 'hide' rather than a 'visible' 
> > setting. It got a bit tricky because the check box is 
> representing an 
> > inverse of the database value, so I implemented a couple of extra 
> > classes to cope.
> > 
> > Comments ?
> > 
> > Cheers
> > 
> > On Thu, 2004-03-04 at 08:53, John Pullan wrote:
> > > On Thu, 2004-03-04 at 07:22, Oscar Carlsson wrote:
> > > > >>JP> This patch adds the visible setting to the channel editor 
> > > > >>JP> (it was pointed out that it was missing on the user list)
> > > > >>
> > > > >>JP> You might want to review the label and help text, words 
> > > > >>JP> ain't my strong point :)
> > > > >>
> > > > >>I'd make it a "hide" option instead, but maybe that's 
> just me..
> > > > >>  
> > > > >>
> > > > 
> > > > JDS> It's been called the visible flag since it went in a while 
> > > > JDS> ago.  This
> > > > JDS> patch just adds it to the gui.
> > > > 
> > > > Sure,  but the user doesn't have to know what the internal 
> > > > structure looks like, and I just felt that from a UI 
> perspective a 
> > > > "hide" flag would make more sense.
> > > > 
> > > > Like:  "why  wouldn't i want to show this channel if i 
> added it to 
> > > > the database, of course i want it to be visible"..
> > > > 
> > > So do we want a new patch or not ? Inverting the logic 
> will require 
> > > more work, not just text changes.
> -- 
> John Pullan <jmp at tarantella.com>
> 




More information about the mythtv-dev mailing list