[mythtv] [PATCH][Discussion]Supporting frequencies nexttofreqid's in MythTV

Paul Koster mythtv at kosteronline.net
Sat Mar 27 08:26:06 EST 2004


From: "Isaac Richards" <ijr at po.cwru.edu>
> Thanks, applied this, though I changed the logic somewhat, as I believe
you
> broke normal operation.

Indeed it seems that I could have been off with a factor 16 in the
old/normal case indeed. I wanted to ensure that TuneToFrequency would get
frequencies in kHz and changed TuneTo accordingly, because frequencies
expressed in kHz*16 are confusing and should preferably not be used accross
functions. I now notice that this can't be done in a trivial way without
introducing rounding errors.

You changed the parameter that is passed to TuneToFrequency:
   frequency = frequency * 16 / 1000 + finetune;
Why do you take into account 'finetune'? Frequency can be entered with a
higher resolution (steps of 1kHz) then finetune can offer (62.5kHz, and they
work on total different scales) so finetune could be left out.

--
Paul



More information about the mythtv-dev mailing list