[mythtv] [resubmit patch] fix for proglist.cpp which fails on some compilers

Tommy Faasen mythtv at zwanebloem.nl
Tue May 11 02:25:11 EDT 2004


Hi,

I'm resubmitting this patch as it hasn't been included yet.

The patch below fixes and compile error which breaks on some machines
according to some people on this list.

My advice is to refrain from the 'or' statement and use '||'.
THe patch is at the end of this message.

Tommy
----- Forwarded message from Tommy Faasen <mythtv at zwanebloem.nl> -----

Envelope-to: mythtv at zwanebloem.nl
Delivery-date: Tue, 04 May 2004 20:07:22 +0200
From: Tommy Faasen <mythtv at zwanebloem.nl>
To: mythtv-dev at mythtv.org
X-zwanebloem-MailScanner: Found to be clean, Found to be clean
Subject: [mythtv] [patch] fix small compile error in libmythtv
X-BeenThere: mythtv-dev at mythtv.org
X-Mailman-Version: 2.1.3
Reply-To: Development of mythtv <mythtv-dev at mythtv.org>
List-Id: Development of mythtv <mythtv-dev.mythtv.org>
List-Unsubscribe: <http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev>,
	<mailto:mythtv-dev-request at mythtv.org?subject=unsubscribe>
List-Archive: <http://mythtv.org/pipermail/mythtv-dev>
List-Post: <mailto:mythtv-dev at mythtv.org>
List-Help: <mailto:mythtv-dev-request at mythtv.org?subject=help>
List-Subscribe: <http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev>,
	<mailto:mythtv-dev-request at mythtv.org?subject=subscribe>

Hi,

I changed 'or' into ||, does 'or' even work for some people??
Or is it a macro thing?

Anyhow patch is attached..

Tommy
----- Forwarded message from Matt Ryan <matt.ryan at xotech-llc.com> -----

Envelope-to: mythtv at zwanebloem.nl
Delivery-date: Tue, 04 May 2004 19:36:29 +0200
From: Matt Ryan <matt.ryan at xotech-llc.com>
To: Development of mythtv <mythtv-dev at mythtv.org>
Subject: Re: [mythtv] Build failures, xebian 1.0.2, qt 3.3.2, gcc 3.2.2
X-BeenThere: mythtv-dev at mythtv.org
X-Mailman-Version: 2.1.3
Reply-To: Development of mythtv <mythtv-dev at mythtv.org>
List-Id: Development of mythtv <mythtv-dev.mythtv.org>
List-Unsubscribe: <http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev>,
	<mailto:mythtv-dev-request at mythtv.org?subject=unsubscribe>
List-Archive: <http://mythtv.org/pipermail/mythtv-dev>
List-Post: <mailto:mythtv-dev at mythtv.org>
List-Help: <mailto:mythtv-dev-request at mythtv.org?subject=help>
List-Subscribe: <http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev>,
	<mailto:mythtv-dev-request at mythtv.org?subject=subscribe>
X-zwanebloem-MailScanner: Found to be clean

 > I just compiled with qt 3.2.x and gcc 2.95.4 with debian
> using yesterday's cvs..
>
>I do remember that at line 609 of proglist.cpp it said
>                if (category <= " " or category == NULL)
>
>I replaced it with the following:
>                if (category <= " " || category == NULL)
>
>Please let me know if that is your problem as well, so i can make a
>patch for it.
>

That fixed it for me too, thanks!

_______________________________________________
mythtv-dev mailing list
mythtv-dev at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev


----- End forwarded message -----

Index: mythtv/libs/libmythtv/proglist.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/proglist.cpp,v
retrieving revision 1.27
diff -u -r1.27 proglist.cpp
--- mythtv/libs/libmythtv/proglist.cpp	25 Apr 2004 19:23:05 -0000	1.27
+++ mythtv/libs/libmythtv/proglist.cpp	4 May 2004 17:46:51 -0000
@@ -606,7 +606,7 @@
             while (query.next())
             {
                 QString category = query.value(0).toString();
-                if (category <= " " or category == NULL)
+                if (category <= " " || category == NULL)
                     continue;
                 category = QString::fromUtf8(query.value(0).toString());
                 viewList << category;

_______________________________________________
mythtv-dev mailing list
mythtv-dev at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev


----- End forwarded message -----


More information about the mythtv-dev mailing list