[mythtv] [PATCH] Limit the updates for nonexisting LCD
ijr at po.cwru.edu
Fri Oct 8 19:52:00 UTC 2004
On Friday 08 October 2004 03:33 pm, Kenneth Aafl°y wrote:
> On Friday 08 October 2004 11:54, Tako Schotanus wrote:
> > Kenneth Aafl°y wrote:
> > > Also, after I had a look at this compile time option I must say I do
> > > not understand why this was even made a compile time option. I would
> > > say that what qualifies as a compile time option is a large part of
> > > code that is either very unstable and/or contains external dependecies
> > > that not every user would want or need to have. LcdDevice is neither,
> > > right?
> > Sorry, have no idea about the rationale for making it a compile time
> > option.
> Do you have an oppinion on this Isaac?
Not really - I think the current stuff could be done better, in that all the
code in the various modules (eg, mythmusic) generally does a lot of extra
work that it wouldn't have to if the lcd weren't present. As long as there's
no additional dependencies, I don't have a problem getting rid of it being a
> Many locations in MythTV use this call, try grepping the libs for it. These
> however mostly is called once on user interaction. It would be nice to have
> this sent from the server along with the return number from a remote Read
> (for example), which could then be cached for calcSliderPos and other
> usage. Does that sound sane?
That makes sense.
> So if I change the 250 in my patch to a 1000 and remove the secsTo() stuff
> it would scale nicely as it would be updated less if the load is high.
I would just move the calcSliderPos bit into the existing code that makes it
only check once a second, personally.
More information about the mythtv-dev