[mythtv] [PATCH] Limit the updates for nonexisting LCD

Kenneth Aafl°y lists at kenneth.aafloy.net
Fri Oct 8 22:12:52 UTC 2004


On Friday 08 October 2004 21:52, Isaac Richards wrote:
> On Friday 08 October 2004 03:33 pm, Kenneth Aafl°y wrote:
> > On Friday 08 October 2004 11:54, Tako Schotanus wrote:
> > > Kenneth Aafl°y wrote:
> > > > Also, after I had a look at this compile time option I must say I do
> > > > not understand why this was even made a compile time option. I would
> > > > say that what qualifies as a compile time option is a large part of
> > > > code that is either very unstable and/or contains external
> > > > dependecies that not every user would want or need to have. LcdDevice
> > > > is neither, right?
> > >
> > > Sorry, have no idea about the rationale for making it a compile time
> > > option.
> >
> > Do you have an oppinion on this Isaac?
>
> Not really - I think the current stuff could be done better, in that all
> the code in the various modules (eg, mythmusic) generally does a lot of
> extra work that it wouldn't have to if the lcd weren't present.  As long as
> there's no additional dependencies, I don't have a problem getting rid of
> it being a compile-time option.

So I'll start making patches like:
 if ( (LvdDevice *dev = gContext->GetLcdDevice()) )
 {
  ....
 }
which would not affect the current behavior at all, and then in the end send 
the patch which really does not create and/or deletes the lcd object if it's 
unable to connect to it's server.

> > So if I change the 250 in my patch to a 1000 and remove the secsTo()
> > stuff it would scale nicely as it would be updated less if the load is
> > high.
>
> I would just move the calcSliderPos bit into the existing code that makes
> it only check once a second, personally.

I was thinking why calculate time x is over y, z times a second for such a 
minute task as updating the lcd display, which could live well with a bit of 
a delay on very high load.

Kenneth


More information about the mythtv-dev mailing list