[mythtv] Re: [mythtv-commits] mythtv commits

Holger Buchfink avalanche at beyondmonkey.com
Sat Oct 23 17:44:50 UTC 2004


Kenneth Aafl°y wrote:
> On Saturday 23 October 2004 17:02, Holger Buchfink wrote:
> 
>>Kenneth Aafl°y wrote:
>>
>>>>- Changes committed by avalanche on Wed Oct  6 01:55:12 2004
>>>>
>>>>Modified Files:
>>>>  in mythtv/libs/libmyth:
>>>>       mythcontext.h util.cpp
>>>>  in mythtv/libs/libmythtv:
>>>>       programinfo.cpp
>>>>  in mythweb/includes:
>>>>       mythbackend.php programs.php
>>>>Log Message:
>>>>Adjustments to ProgramInfo::To/FromStringList(), makes backend queries
>>>>10x faster. Note that ProgramInfo::ToStringlist() now encodes dates as
>>>>UTC. Update MythWeb accordingly, also fix the preview pixmap backend
>>>>query. Proto bump.
>>>
>>>The changes to FromStringList/FromScheduler will deadlock if the String
>>>count does not match exactly, any ideas to fix that just in case?
>>
>>Only problem I can see is a big float overflowing the tmp buffer. I'll set
>>it to 64 on my next commit. Can you check if that was it?
> 
> 
> I wasn't talking about a overflow, but that is something that also can go 
> wrong in the future, but I doubt stars will overflow right now. The check for 
> the end of the doubly linked list however, can wrap in fromstringlist, which  
> will cause a ~infinite deadlock in fromscheduler. I have not checked if this 
> might occur at other places in programinfo. A check for a null string on 
> conversion to ascii would be nice too.

You were however, talking about it being related to the changes made,
the check for end of list wasn't part of the changes, been there long
before. It is indeed a problem, I guess the only way to handle it would
be to check for a valid iterator before a list element is read. I'll
take a shot at it and throw in some null checking in both
To/FromStringList().

Holger



More information about the mythtv-dev mailing list