[mythtv] [PATCH] Multi Artist patch for MythMusic - I'd call it RC1 by now...
mythtv at lamedomainname.com
Fri Sep 3 17:50:09 EDT 2004
On Monday 30 August 2004 03:50 am, Colin Guthrie wrote:
> when you've got some comments about the patch.
This is great progress. Some thoughts though:
You seem to have commented out existing db updates in dbcheck.cpp and then
used the same version number as the updates you commented out for your own
updates. So ... anyone running cvs (current) does not get the updates
applied, which results in the table being older than the code expects, which
results in music scanning that finds no tracks available.
The CTRL-Right thing to move around the ripping table is a bit of a mess,
although mitigated by your swap button.
The main shortcoming of the code as it stands, as you've already pointed out,
is that people who rip to mp3's won't have the albumartist information
preserved in the file itself. Would be awfully nice to fix that, although I
know it means a lot of work for getting decent id3v2 tag code in there.
On a more general thought, the dbcheck code you commented out is stuff I'm
actively working on for mfd/mfe. These columns/metadata fields are exactly
the same ones that iTunes uses internally. More importantly, they are also
the same fields that the daap protocol (e.g. iTunes music sharing) uses. The
mfd uses (well, will use) daap to automagically share music content between
myth boxes. It's important, therefore, to try and keep daap compatability in
mind when thinking about new metadata fields.
One of these columns is a bool called compilation. That should almost
certainly be used by any album-artist type code (and, obviously, set to true
if the album is a compilation). That way, any display and/or wire-protocol
logic can do a bool check independent of whether albumartist is or is not
set/equal to track artist, etc.
More information about the mythtv-dev