[mythtv] [PATCH] Multi Artist patch for MythMusic - I'd call it RC1 by now...

[thor]

On Saturday 04 September 2004 09:27 am, Colin Guthrie wrote:

> I don't know how the whole Schema version stuff works
> with CVS but I take it that there has to be a little bit of manual DB
> tweaking when working on CVS as I guess the schema should only really
> change on actual public releases (e.g. 0.16)?
>

	No, the schema can change as often as it needs to. If a user only installs 
releases (0.13, 0.14, 0.15, etc.), they will simply have more than one 
db_check update run the first time the latest install is run.

> Am I right in saying I should probably just integrate my shema changes
> with yours and keep the version number the same?

	No, you should set up your changes so that they take the music db stuff to 
version to 1003, and the function to go from 1002 to 1003 would include your 
alterations (and the version number at the top would need to go to 1003). 
Note that you also need to include your alterations in the case where there 
is no previous version schema (i.e. for a new install on a machine that has 
never run mythmusic).

>
> I can do this. Although I don't like MP3 format for quality/patent
> reasons, it shouldn't take too long to replace this stuff. I think the
> id3lib stuff is a dependancy anyway, so no additional packages should be
> needed.
>

	That would be great. Lots of users do seem to like mp3 (compatability with 
other devices, I guess), and we would hear no end of complaints if a music 
rescan after some sort of configuration change "lost" all the albumartist 
info  :-)



> Yeah, that sounds like a very sensible idea. The compilation bool can be
> incorporated into the stuff I'm doing.

	Yeah, I think that makes sense.


> Would it make more sense if I used the "composer" field to indicate the
> Album Artist rather than my own field? In ID3v2 there is a separate
> "Composer" field, TCOM which could be checked too and used in preference
> to the TPE4 field... It may be better to keep this separate tho' as it
> is different, just quite close...

	I dunno, but I think it would be better to keep an albumartist field, as it 
really is different than composer. Whenever displaying a tree view of data, 
we would use the albumartist string in place of artist _if_ the compilation 
bool is true. 

	My only worry is that albumartist (or equivalent) is not a "standard" field, 
so users won't be able to use tools like easytag to tweak their music 
libraries.
	
> Also, I take it your patch probably changes a lot of the same files ;)
> This may make it a litte awkward to apply both! If there is anything I
> can do to make things simpler then let me know (e.g. a separate branch
> or separate CVS or something?)

	No patches, all my stuff is in current CVS. The only thing that mfd/mfe 
impacts directly on the original mythmusic code base is the database schema, 
and that's been in for quite a while.

	Once you've got your stuff ready to go in, I'll have to update mfd/mfe to 
understand the updated table info and logic.

- thor