[mythtv] Any missed patches?

[Ed Wildgoose]

Isaac Richards wrote:

>Any missed patches (non mythweb) that I've not either commented on or not 
>applied?  I believe I got everything with [patch] in the subject line that 
>was ready for CVS..  Anyway, I'm done applying things for the night. =)
>  
>

I don't quite see how or why, but my patch titled "Fix clicks and pops 
in OSS output", that you said you had applied, isn't applied..?

It's re-attached.

Note also that there are some other alsa fixes floating around, the one 
with the title "Broken pipe fix" looks the most promising for being 
applied (you commented on it only that there were too many comments, but 
the rest of the patch surely looks fine?).  I see a regular issue with 
any under/over run causing audio to just stop until you quite and 
re-enter (which is somewhat annoying), this looks like the answer


Thanks

Ed W
-------------- next part --------------
Index: libs/libmyth/audiooutputoss.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmyth/audiooutputoss.cpp,v
retrieving revision 1.15
diff -u -r1.15 audiooutputoss.cpp
--- libs/libmyth/audiooutputoss.cpp	29 Mar 2004 22:41:38 -0000	1.15
+++ libs/libmyth/audiooutputoss.cpp	11 Aug 2004 23:20:07 -0000
@@ -547,7 +547,7 @@
             // should this use ioctl(audio_fd, SNDCTL_DSP_POST, 0) instead ?
             
             space_on_soundcard = getSpaceOnSoundcard();
-            if (fragment_size < space_on_soundcard)
+            if (fragment_size <= space_on_soundcard)
             {
                 WriteAudio(zeros, fragment_size);
             }
@@ -567,7 +567,7 @@
         /* do audio output */
         
         // wait for the buffer to fill with enough to play
-        if (fragment_size >= audiolen(true))
+        if (fragment_size > audiolen(true))
         {
             VERBOSE(VB_AUDIO, QString("audio thread waiting for buffer to fill"
                                       " fragment_size=%1, audiolen=%2")
@@ -601,7 +601,7 @@
 
         // re-check audiolen() in case things changed.
         // for example, ClearAfterSeek() might have run
-        if (fragment_size < audiolen(false))
+        if (fragment_size <= audiolen(false))
         {
             int bdiff = AUDBUFSIZE - raud;
             if (fragment_size > bdiff)