[mythtv] [PATCH] mythmusic: Fix CD metadata display & marking of
selected CD tracks
froods at alphalink.com.au
Mon Sep 13 04:44:59 EDT 2004
This patch addresses the following bugs when selecting music:
1. When CD tracks are highlighted the metadata displayed is for an
MP3/etc file, not the CD track.
2. After clearing the active playlist and then adding only CD tracks to
it, exiting the select music screen and returning to it will show some
MP3 files as also being selected.
Both of these bugs are due to the use of duplicate identifiers for MP3
files and CD tracks. The metadata classes use negative IDs for CD
tracks and positive IDs for MP3 files. Currently the TreeCheckItems
store both IDs as positive, and don't always translate properly when
calling the metadata functions. Also, the function that sets check
marks appropriately when entering the select music screen doesn't
distinguish between CD tracks and MP3 files, just using the positive ID
which matches both.
The patch stores negative IDs for CD tracks in the tree items so all
calls for metadata are consistent. It also adds a cd_flag to
Playlist::checkTrack(). Because playlists themselves are stored in
TreeCheckItems with negative IDs extra checks are in place to
distinguish these from CD tracks.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5653 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040913/29d21a18/music-cditems-0001.bin
More information about the mythtv-dev