[mythtv] [BUG] [PATCH] DVB: problems figuring out the length of
a recording in TS mode
willu.mailingLists at cse.unsw.edu.au
Thu Apr 7 22:10:52 UTC 2005
On Thu, 07 Apr 2005 10:46:35 +0800, Nathan Manzi
<plasma at synaptik.com.au> wrote:
> Pekka Jääskeläinen wrote:
>>> The patch is incorrect.
>> Too bad. Any better fix in queue?
> The patch tries to do too much.
> Commenting/Removing '_scanning_pes_header_for_gop' in the video slice
> section of dtvrecorder.cpp fixes the problem.
I really wish I'd never posted the broken patch. People don't seem to
realise I posted a working patch a day later. sigh.
Both patches work the same way - they remove
_scanning_pes_header_for_gop entirely. The problem with the broken
patch wasn't that it tried to do too much, it was that it did too
little - I missed some references to _scanning_pes_header_for_gop.
Anyway, the second patch I posted, and the patch attached to the bug
report, both work. If anyone disputes this, please let me know what is
wrong so that I can fix it!
Otherwise, can we let the broken patch go... the (incorrect) meme that
there is no working patch only makes it harder to get the fix
Dr William Uther National ICT Australia
Phone: +61 2 9385 6357 Computer Science and Engineering
Email: willu at cse.unsw.edu.au University of New South Wales
Web: http://www.cse.unsw.edu.au/~willu/ Sydney, Australia
More information about the mythtv-dev