[mythtv] Re: Re: [PATCH] MythMusic smart playlist update

Paul mythtv at dsl.pipex.com
Thu Apr 7 22:51:47 UTC 2005


>>
>> Thanks for trying the patch. The attached revised patch does what you
want.
>> Changed the behaviour to always allow you to save the smart playlist so
long
>> as it is valid even if it doesn't return any results. Also fixed a small
>> issue where
>> the new date edit dialog didn't have an initial focus set to a widget.
>>

>Thanks, seems to work a treat.
>Am I being slow, but is there any need for +'ve offsets to $DATE?
>Daylight saving issues aside :).

No you are right it makes no sense at all. At first the +/- days
value was applied to both the fixed date and use current date
values but half way though developing it I changed it to only apply
to the use current date option. It just needs the maximum value
in the addDaysSpinEdit widget set to 0 and the addDaysCheck
text changing to something more appropriate.

>Except you slipped in a change of "is not equal" to "is not equal to"...

 I didn't think anybody would notice this :-). This change does break
existing
smart playlists that use the "is not equal" operator. Should be easy to fix
them
by opening them in the editor and changing the operator to "is not equal to"
and
resaving them I think. There is a good reason for the change though.
In case you are interested its all to do with the way the combo boxes get
automatically resized by the qhboxlayout to accommodate the widest string in
their item list. Because the new date and boolean fields use only a subset
of the operators that the string and numeric fields use the combo boxes
where
being resized to different widths depending on the field type each of the
criteria
rows where set to which screwed the screen layout up. By changing the "is
not equal"
to "is not equal to" that operator becomes the widest string in the operator
list.
Because it is common to all field types all the combo boxes end up the same
size
regardless of the field chosen.

I'll probably wait and see what Isaac thinks about the change.
If he thinks its a problem I will change it back to "is not equal" and think
of another
way to make sure the combo's get resized correctly.

Paul






More information about the mythtv-dev mailing list