[mythtv] Re: DVB fix?

Jesper Sörensen jesper at datapartner.se
Fri Apr 8 13:22:21 UTC 2005


William Uther wrote:

>   Just a brief follow-up WRT the DVB TS frame counting patch.  I know 
> you're busy, but I was hoping to get this into 0.18.  Any chance of 
> committing by the weekend?


William,
I don't have commit access so it's not me you need to convince, and I 
haven't worked on that part of the code before so my words probably 
don't carry a lot of weight but let me say some things anyway... :-)

You obviously found a real bug but are you 100% sure that the cause 
really is that some channels don't set the PUSI flag on picture frame 
packets (sounds strange)? How did you arrive at that conclusion? I 
definitely think you are very close (expecially since you say your patch 
works) but maybe there is a less intrusive way to fix it? (This code is 
used for ATSC/HDTV as well and it would suck to break something so close 
to 0.18.)

For what it's worth, do you think that the patch below could have an 
effect? It looks a bit weird with bit ops there so I think this patch 
makes the code do what the author actually meant? (Not sure if it 
actually matters with true/false stuff though and my brain isn't running 
at 100% right now, Friday afternoon and all... 8-)

Index: libs/libmythtv/dtvrecorder.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/dtvrecorder.cpp,v
retrieving revision 1.9
diff -u -r1.9 dtvrecorder.cpp
--- libs/libmythtv/dtvrecorder.cpp    23 Feb 2005 05:04:36 -0000    1.9
+++ libs/libmythtv/dtvrecorder.cpp    8 Apr 2005 12:32:27 -0000
@@ -97,7 +97,7 @@
     bool noPayload = !tspacket->HasPayload();
     bool payloadStart = tspacket->PayloadStart();
 
-    if (noPayload | (!payloadStart & !_scanning_pes_header_for_gop))
+    if (noPayload || (!payloadStart && !_scanning_pes_header_for_gop))
         return; // not scanning or no payload to scan
 
     if (payloadStart)



More information about the mythtv-dev mailing list