[mythtv] Re: [mythtv-commits] mythtv commit: r8268 by ijr

Isaac Richards ijr at case.edu
Wed Dec 14 17:23:03 EST 2005


On Wednesday 14 December 2005 17:14, Daniel Kristjansson wrote:
> On Wed, 2005-12-14 at 21:30 +0000, mythtv at cvs.mythtv.org wrote:
> >       Author: ijr
> > New Revision: 8268
> > Daniel, please review the tv_rec changes - there was a nasty race between
> > StartRecording and StopLiveTV and I'm not sure if my fix is entirely
> > correct. The kill ringbuffer command in StopLiveTV would run after
> > everything in StartRecording had and kill the newly created ringbuffer.
>
> This looks right.
>
> That code was in there from the old LiveTV implementation, where the
> frontend took care of killing the ringbuffer at the end of LiveTV
> with StopLiveTV(), and reused the ringbuffer on channel changes.
>
> Now we should be using the kill ringbuffer flag with LiveTV like we
> do for recordings; which this change does.

Great.  That was, ah, not exactly fun to find. =)

Isaac


More information about the mythtv-dev mailing list