[mythtv] Re: [mythtv-commits] Re: Ticket #832: SVN: 8306 - Channel icon import fails with ampersands in iconmap.xml

[Steve Adeff]

On Thursday 22 December 2005 17:08, Bruce Markey wrote:
> MythTV wrote:
> > #832: SVN: 8306 - Channel icon import fails with ampersands in
> > iconmap.xml
> > -----------------------------------+-------------------------------------
> >--- Reporter:  steve.adeff at gmail.com  |        Owner:  ijr
> >      Type:  defect                 |       Status:  new
> >  Priority:  minor                  |    Milestone:
> > Component:  mythtv                 |      Version:  head
> >  Severity:  low                    |   Resolution:
> > -----------------------------------+-------------------------------------
> >--- Comment (by adeffs at gmail.com):
> >
> >  my first patch, so don't ream me =)
>
> That works but "diff -u" is much better, especially for larger
> patches and SVN diff from the top directory of the source is best.
>
> : bjm at moktoo ; svn di contrib/mkiconmap.pl
>
> Index: contrib/mkiconmap.pl
> ===================================================================
> --- contrib/mkiconmap.pl        (revision 8359)
> +++ contrib/mkiconmap.pl        (working copy)
> @@ -178,6 +178,9 @@
>
>  sub stubbed_url {
>         my ($full_url) = @_;
> +       if ($full_url =~ m/&/) {
> +               $full_url =~ s/&/&amp\;/g;
> +       }
>         my ($url, $icon_file) = split_url_from_file($full_url);
>         if (exists $master_urls{$url}) {
>                 return "[" . $master_urls{$url} . "]/$icon_file";
>
> --  bjm

u know, I was trying to figure out how to create that style patch, but the man 
page isn't really clear on it. Thanks for letting me know. I'm teaching 
myself PERL now, which is why I created this, so I'm going to look through 
the Myth perl scripts to see if I can enhance them, might offer some more 
diffs soone =)

thanks Bruce!

-- 
Steve