[mythtv] Backtrace: Goom segfaults

Carl Alexander carlalex-mythtv at overlords.com
Mon Feb 21 00:10:18 UTC 2005


Yes, that may fix the crash at that point, but the question is *why* is 
it going wrong?  What is the design or implementation inconsistency that 
is causing this? I haven't groked enough of the code to answer that.

has anyone valgrind'ed the code? Maybe a UMR or a over read is filling 
some of the variables with garbage data.


    --- Carl



Ed Wildgoose wrote:
> Pressed wrong key.  I'm trying this patch/hack:
> 
> Index: mythmusic/goom/filters.c
> ===================================================================
> RCS file: /var/lib/mythcvs/mythmusic/mythmusic/goom/filters.c,v
> retrieving revision 1.4
> diff -u -r1.4 filters.c
> --- mythmusic/goom/filters.c    26 Jan 2005 06:01:01 -0000      1.4
> +++ mythmusic/goom/filters.c    20 Feb 2005 14:51:03 -0000
> @@ -422,6 +422,8 @@
>                px = brutSmypos + (((brutD[myPos] - brutSmypos) * 
> buffratio) >> BUFFPOINTNB);
>                brutSmypos = brutS[myPos2];
>                py = brutSmypos + (((brutD[myPos2] - brutSmypos) * 
> buffratio) >> BUFFPOINTNB);
> +               if (px<0) px = 0;
> +               if (py<0) py = 0;
> 
>                pos = ((px >> PERTEDEC) + prevX * (py >> PERTEDEC));
>                // coef en modulo 15
> 
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev



More information about the mythtv-dev mailing list