[mythtv] [patch] AC3 patches

[Jesper Sörensen]

I have looked over Mark Anderson's AC3 patches... Patch 4 was still a 
bit messy so I decided to split it up + I removed the auto-pid hack for 
the DVB PS recorder since it will not be needed much longer if all goes 
according to plan.

I also re-diffed all patches against current CVS to make them easier to 
apply. I don't want to steal any credit from Mark and those who helped 
him - I just want to make this as easy as possible for Isaac. :)

Attached you will find the following patches:
ac3-1    - scanstream crash fix
ac3-2    - stream change callback
ac3-3    - ac3 header fix for transform.c
ac3-4.1    - deal with audio codec changes in avformatdecoder
ac3-4.2    - setup GUI for ac3wanted option
ac3-4.3    - make avformatdecoder auto-select AC3 (if "ac3wanted")

Please see Mark's messages for more detailed explanations.

Marcus Metzler OK:ed the transform patch and as I see it patch 1, 2, 3 & 
4.1 should be good to go. Patch 4.2 & 4.3 might still be a bit 
controversial?

4.2: In my opinion we do need an "ac3wanted" option also -- 
ac3passthrough doesn't quite cut it. The exact option name, wording of 
the help text, position in the GUI etc. doesn't really matter so if 
someone has any other ideas for it please go ahead with that instead.

4.3: The AC3 auto-select functionality would be really nice for those of 
us with both regular audio tracks and AC3. If I have understood this 
correctly, with the first four patches AC3 *should* work but you might 
need to hit the '+' key to get it to switch over to the AC3 track. It 
looks a bit awkward the way it is implemented in this patch but since I 
don't have a better idea for it right now I'll leave it as it is. If it 
isn't "good enough" maybe someone can fix it up? If not I can put it on 
my todo list but it's already pretty long so it might take a while. :-/

Isaac, will you please consider these patches for inclusion in Myth CVS? 
At least patch 1-4.1 since they are the most crucial patches to get AC3 
working...

BTW, thanks for your excellent work Mark, and everyone else who helped 
with this! :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ac3-patches.tbz
Type: application/octet-stream
Size: 3504 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050127/91f53720/ac3-patches.obj