[mythtv] RE: [mythtv-commits] mythtv commit: r6959 by danielk

[Anduin Withers]

./mythtv/libs/libmythtv/avformatdecoder.cpp line 143 isn't C++, no new
(short int)[size] (looks like a placement but isn't), the parens around
short int should be removed.

-- 
Anduin Withers


> -----Original Message-----
> From: mythtv-commits-bounces at mythtv.org [mailto:mythtv-commits-
> bounces at mythtv.org] On Behalf Of mythtv at cvs.mythtv.org
> Sent: Friday, July 29, 2005 1:02 PM
> To: mythtv-commits at mythtv.org
> Subject: [mythtv-commits] mythtv commit: r6959 by danielk
> 
>       Author: danielk
>         Date: 2005-07-29 17:01:31 +0000 (Fri, 29 Jul 2005)
> New Revision: 6959
>    Changeset: http://cvs.mythtv.org/trac/changeset/6959
> 
> Modified:
> 
>    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
>    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.h
>    trunk/mythtv/libs/libmythtv/avformatdecoder.cpp
>    trunk/mythtv/libs/libmythtv/avformatdecoder.h
>    trunk/mythtv/libs/libmythtv/decoderbase.cpp
>    trunk/mythtv/libs/libmythtv/decoderbase.h
>    trunk/mythtv/libs/libmythtv/ivtvdecoder.cpp
>    trunk/mythtv/libs/libmythtv/nuppeldecoder.cpp
> 
> Log:
> 
> This addresses #145.
> 
> I discovered that the problem is that something in the libav or
> avformatdecoder overwrites the avformatdecoder class with audio
> data. I haven't figured out where this is happening, but by
> allocating the audio buffer on the heap, instead of as an
> array in avformatdecoder, the SEGFAULT doesn't happen.
> 
> However the video has a few lines of bright green on the top of video.
> And those blocks move about a bit on the P & B frames. It's almost as
> if a slice was missing. The sound is working, so I'm not sure what is
> going on.
> 
> 
> This commit also cleans up variable initialization in the involved
> classes and provides a couple Set's & Get's for the NVP and
> RecorderBase pointers in RecorderBase and NVP, respectively.
> 
> 
>