[mythtv] [PATCH] Add single retry of connection to master backend

Allan Stirling Dibblahmythml0015 at pendor.org
Wed Jun 15 19:12:00 UTC 2005


Isaac Richards wrote:
> On Wednesday 15 June 2005 10:53 am, Allan Stirling wrote:
> 
>>Allan Stirling wrote:
>>
>>>If the master backend is restarted, the frontend presents an error ("The
>>>connection to the master backend server has gone away for some
>>>reason..") to the user. This is probably unnecessary, since a retry will
>>>fix the situation.
>>>
>>>The only reason I see not to change this code is so the end-user is
>>>notified when the backend is restarted. However, in a non-development
>>>environment (where WAF is concerned),  the dialog doesn't exactly add
>>>value.
>>>
>>>The attached patch adds a single retry of the connection. It also cleans
>>>up the function somewhat - The "// this should be obsolete..." section
>>>has been around since December 2003.
>>>
>>>I don't see the associated cerr in any of my logs. If this is incorrect,
>>>I'll resubmit the patch with just the functional changes.
>>>
>>>Cheers,
>>>
>>>Allan.
>>
>>Is this just a bad idea? Badly implemented?
> 
> 
> Sorry for not responding earlier - I've been too busy with other things to 
> deal with patches just yet.  Why'd you get rid of the BACKEND_MESSAGE 
> handling, though?
> 
Sorry - The patch maybe isn't very clear. I'd assumed that the section 
marked "// this should be obsolete..." was obsolete, since it's been 
around for some time and I've seen no comments asking what this strange 
error in their backend output is.

http://cvs.mythtv.org/cgi-bin/viewcvs.cgi/mythtv/libs/libmyth/mythcontext.cpp?r1=1.93&r2=1.94

If it's incorrect, I'll gladly redo the patch to remove the obsolete 
comment, if it's incorrect.

Cheers,

Allan.


More information about the mythtv-dev mailing list