[mythtv] [PATCH] Fix (now broken) screen settings
Nigel Pearson
nigel at ind.tansu.com.au
Wed Mar 9 22:19:11 UTC 2005
>> to revert yesterday's patch and get this correction.
>
> Or patch "-R" or cp -rp from an unpatched tree, etc...
Sure, but I have made enough stupid mistakes lately
that doing a reverse patch is just too risky :-)
>> 2) There may still be problems with the window sizing.
>> (at the very least, I expect tiling/cropping issues)
>> If so, try this revised version of yesterday's patch
>> (attached)
>
> With this patch, the things I've tested so far seem to be correct.
> With and without GUI dimensions, with and without GuiSizeForTV set,
> on a computer monitor desktop or TV, and with or without window trim,
> the GUI size and playback size switch to the correct sizes as expected.
> Myth's internal overscan values and aspect ratio modes all seem to
> still work correctly.
Overscan too? Excellent.
(though, I haven't made any changes to the overscan stuff)
> I don't have xvmc or any videoout other than Xv so I can't verify
> anything else.
I think the Xv and XVMC videoout stuff is identical
in the geometry respect (being a derivative work), and I
did made the same change to both, so both should be good?
> However, I'd recommend applying this as the current
> CVS behavior is not correct.
I am tempted to leave it another day or two for others
to check, but I guess there is no-one else reading this thread,
so OK - in it goes.
I also have one more method planned in mythcontext.cpp,
for my future command-line geometry parsing changes.
I may slip the method signature and empty method in now,
so that adding the new code will not require an annoying
recompile of everything that depends on mythcontext.h
(i.e. I have annoyed all you other developers enough lately.
No need to exacerbate it!)
--
Nigel Pearson, nigel at ind.tansu.com.au | "Peacemaking is our profession"
Telstra BI&D, Sydney, Australia | Motto of Burpelson Airforce Base
Office: 8255 4222 Fax: 8255 3153 | Commanded by Gen. Jack D. Ripper
Mobile: 0408 664435 Home: 9792 6998 | Dr Strangelove
More information about the mythtv-dev
mailing list