[mythtv] [PATCH] mythmusic: autoplay of CDs
ijr at case.edu
Tue May 3 07:41:34 UTC 2005
On Sunday 10 April 2005 09:43 am, Herman Kuiper wrote:
> > Not applying this, because:
> > - it was generated with -b -B, which completely trashes the indentation
> > of a few changes you made.
> Ah ok, I didn't know that.
Of course, if you ignore whitespace, you can't go editing random other code.
There's too many unnecessary changes in this patch.
> > - it duplicates quite a bit of code into playbackbox.cpp
> Do you mean: "within playbackbox.cpp" - if so, I further removed some
> duplicity. If you mean "compared to databasebox.cpp" I would like to
> disagree slightly: I re-use the actual CD reader thread, and only duplicate
> the stuff to setup timer and thread, which are different from the
> Attached a new patch (diff'ed to todays CVS), which includes lots of
> white-space diff's as my editor strips end-of-line whitespace.
> If you still have issues with duplicity, could you give me something more
> on what I might need to change?
No, apart from the unnecessary change issue, the patch looks fine now. I
won't apply until that's fixed, though.
More information about the mythtv-dev