[mythtv] [PATCH] generic avformat seek support (3)

John P Poet jppoet at gmail.com
Mon May 9 01:15:51 UTC 2005


On 5/8/05, Mark Spieth <mark at dclabs.com.au> wrote:
>  
> found a couple of bugs testing with mpg files. 
> This 3rd patch fixes them. 
> a noticable change is the addition of SEEK_END support to RingBuffer::Seek
> so that the file length can be determined by libavformat. 
> there are probably other things wrong but will eventually figure them out. 
> exactseeks is enabled for all libavformat seeks at the moment (no db seek
> info available) 
> Im also looking at the timestamp wraparound problem and have some ideas Im
> trying. 
> cheers 
> _______________________________________________

Version 1 of your patch works pretty well with all three AVI files I
have thrown at it.  It does not works so well for the MPG file I tried
to import from my ReplayTV, but that is not surprising since the
Replay is not know for writing out "proper" mpeg2 files.

Versions 2 and 3 do not fair so well.  They work fine for one of the
AVI files, but not for the other two.  For both of the "other two" the
show length is displayed as being just 2 seconds, and jumping around
in those shows does not work.  Version 2 and 3 also do not handle the
ReplayTV mpeg2 file.

The AVI files which do not work with version 2 or 3 are around 350
megabytes.  I would be willing to make one of them available to you if
you want to go to the trouble of downloading it (I have 256kbit upload
speed on my cable modem).  I could try cutting one of them into a
smaller piece, but am not sure I have the right tools for the job.

If Version 3 gets merged with the current CVS, I will just create my
own diff to allow me to continue using version 1.

Thanks for your effort in making this possible.

John


More information about the mythtv-dev mailing list