[mythtv] Re: [PATCH] EPG Improvements

Harvard Pan harvardpan at gmail.com
Tue May 10 08:21:52 UTC 2005


Alright, I've put in the dialog and posted it on my web site. You can
grab it from:

http://home.comcast.net/~harvardpan/EPGUpdated05102005.diff.bz2

In it, I have the dialog coming up when the channel is unavailable.
FYI, since the check for an available recorder happens before the
current player is stopped, it may seem like the system is a bit
sluggish when changing channels on remote backends. I think it's an
acceptable wait time, but please let me know if someone disagrees.

Also, I finally tracked down the SEGFAULT that occurs when some popup
dialogs happen from within the TV object. The reason for the segfault
is that the program guide is run from a forked thread inside the TV
object. However, when an error occurs in the TV object, a method in
mythfrontend's main.cpp calls "delete tv". The TV object is
destructed, but the program guide is still running. When the program
guide destructs, it returns the context to an already destroyed
parent, which causes the crash. I've fixed the crash by checking
tv->IsMenuRunning() and making sure that if a menu is running, we
don't delete. Please pick up the changes from main.cpp to fix this
crash.

--Harvard

On 5/9/05, Harvard Pan <harvardpan at gmail.com> wrote:
> True, there's no current notification. How about this.. I'll post a
> separate patch tonight on my site of a patch with the notification,
> and one without. I already have the code ready, just need to test it
> first. Whoever ends up applying the patch can decide ultimately which
> one gets committed. I think both methods have their merits, but I
> don't think I'm the one that should be making the decision.
> 
> Thanks for your input, Brian!
> 
> --Harvard
> 
> On 5/9/05, Brian C. Huffman <huffman at graze.net> wrote:
> > Harvard Pan <harvardpan at gmail.com> wrote:
> > > If there are no new recorders or new inputs available, it will go back
> > > to the current recorder and input. It behaves exactly like
> > > ToggleInputs and SwitchInputs does today (when you press Y or C) in
> > > that it sets the flags, which kills the current player and tries to
> > > find the next one. Since it's in the Live TV EPG, there's always at
> > > least one recorder available (the current one).
> > >
> > > There could be a check put in for whether there is a free recorder
> > > available BEFORE you kill the current one. the problem with that is
> > > you could still run into the same problem of not finding one after you
> > > restart (since another frontend or recording process can take it in
> > > the interim), so you don't really end up solving anything.
> > >
> > > Let me know if that's what people want though, and I can always change
> > > the code to do so. I felt that keeping it consistent with the current
> > > behavior was more important, since that's what people will be familiar
> > > with.
> > >
> >
> > True - there's always one recorder available, but it may not have access to the
> > channel you request.  In that case, the way things currently stand, there's no
> > notification to the user of why it did "nothing" when he / she selected a new
> > channel.
> >
> > Brian
> >
> >
>


More information about the mythtv-dev mailing list