[mythtv] [PATCH] Remove use of deprecated DVB events.

Kenneth Aafl°y lists at kenneth.aafloy.net
Thu Sep 1 12:30:18 UTC 2005


torsdag 01 september 2005, 04:53, skrev Stuart Auchterlonie:
> On Thu, Sep 01, 2005 at 03:39:19AM +0100, Stuart Auchterlonie wrote:
> > I've rewritten this using select to check for info from the frontend.
> > It is also using the timeout that is passed to TuneTransport from
> > everywhere it is being used. So far this is working quite well for me.
> >
> > Let me know how things go.
> >
> > This applies on 7192. Alternatively, apply keiths other patch first.
>
> It would really help if I attached the patch :-(

Wonder where I got the idea that the status wasn't returned through ioctls
pointer argument, doh!

Good idea, since the select will poll for events and the events is signaled 
from dvb_frontend's kernel thread on status changes:

                        if (fe->ops->read_status)
                                fe->ops->read_status(fe, &s);
                        if (s != fepriv->status) {
                                dvb_frontend_add_event(fe, s);
                                fepriv->status = s;
                        }

I'm confused however, about what the first select+read_status is for,
since it's not actually doing anything. Was the intention that it
should have triggered a retune if lock had been lost?

Tiny problem with this is that as long as you don't empty the event queue,
the select will return with isset even if it timed out while waiting 
(dvb_frontend.c:dvb_frontend_poll).

Kenneth


More information about the mythtv-dev mailing list