[mythtv] Re: [mythtv-commits] Re: Ticket #385: DVBChannel cleanup

Allan Stirling Dibblahmythml0015 at pendor.org
Wed Sep 28 10:37:44 UTC 2005


>Colin McCormack wrote:
> Wow.  I have seldom seen such incivility for such a clueless reason,
> unless an underdosage of major tranquilizers was involved.
> 
> Someone cleans up some code for you, removing redundant includes, ...

I'm afraid I would have to disagree here. Doing this piecemeal has *no* 
benefit whatsoever to the end-user or even package maintainers.

Indeed, it can be dangerous, since some includes (I'm meaning system 
includes here) are different on different system - So just stripping out 
includes until it doesn't compile on your platform does not work.

That may not the case here, of course - The changes may be entirely in 
Myth internal code, but it is necessary to be careful.

However, if this optimization is to be done, it could possibly be much 
more productive if it could be automated (configure #defines may make 
this slightly difficult) and run over the entire codebase.

BTW, I see no reason for these changes:
  	7	#ifndef _LIBMYTHTV_DVBCHANNEL_H_
  	8	#define _LIBMYTHTV_DVBCHANNEL_H_
	17	 	
  	106	#endif//_LIBMYTHTV_DVBCHANNEL_H_


The other option, of course, is pre-compiled headers. But that's a can 
of worms in itsself.

Cheers,

Allan.


More information about the mythtv-dev mailing list