[mythtv] [mythtv-commits] mythtv commit: r9780 by danielk
David Matthews
dm at prolingua.co.uk
Sun Apr 23 19:51:57 UTC 2006
Pekka Jääskeläinen wrote:
> This changeset breaks DVB subtitles for me completely.
>
> (Changeset: http://cvs.mythtv.org/trac/changeset/9780)
>
It looks as though my patch for dvbsubdec.c was a little too radical.
I've looked again at that code and it seems the switch below where I
made the change in dvbsub_parse_pixel_data_block has various cases that
don't actually write into pbuf. It could be that these cases are
occurring in the Finnish subtitling after the data block is complete.
I've tested a version which does the bounds checking only before the
calls to dvbsub_read_2bit_string etc and that avoids the crash I was
having. I'll submit the patch and maybe someone in Finland could test
it before Daniel commits it.
David
More information about the mythtv-dev
mailing list