[mythtv] [mythtv-commits] Ticket #2210: DVB subtitles are not enabled after exiting from the teletext view

[Frank Muenchow]

Daniel Kristjansson schrieb:
> On Mon, 2006-08-21 at 22:50 +0200, Frank Muenchow wrote:
>>>> Here in Finland the default OSD menu action "Toggle Teletext Captions"
>>>> does nothing. Maybe that's because in here teletext subtitles are not
>>>> sent in some default page or something..
>>> That is probably the reason. I don't know how the myth teletext subtitle 
>>> support works exactly. Here in the UK on analogue page 888 is always 
>>> subtitles but whether when enabling teletext subtitles we automatically turn 
>>> to this page ...
>>>
>> Myth *should* select (for DVB) the teletext subtitle pages from the
>> teletext table. (at least, it does for some samples I have)
>> If teletext subtitles are available, you should have a submenu (called
>> "Select DVB CC") where you can select which language to use.
>> The "Toggle Teletext Captions" uses the first available subtitle page.
>> When you are in teletext mode (using "Toggle Teletext Menu"), you can't
>> see any other OSD, because you are in teletext mode which has only the
>> keys for the teletext active.
> 
> Frank, if this works for all your test streams I'll give my test streams
> a
> check, hopefully this works for everybody, if not we can revert and fix
> this post-0.20.
> 
> -- Daniel
I just tried it and it does not work.
I have to change it a little:

Index: libs/libmythtv/NuppelVideoPlayer.cpp
===================================================================
--- libs/libmythtv/NuppelVideoPlayer.cpp        (revision 10888)
+++ libs/libmythtv/NuppelVideoPlayer.cpp        (working copy)
@@ -1574,11 +1574,11 @@
     /* If subtitles are enabled before the teletext menu was displayed,
re-enabled them */
     if (prevTextDisplayMode & kDisplayAllCaptions) {
         textDisplayMode = prevTextDisplayMode;
+        EnableCaptions(textDisplayMode, false);
     }
     else {
         textDisplayMode = kDisplayNone;
     }
-
 }

 void NuppelVideoPlayer::ResetTeletext(void)


and then it works with dvb-teletext subtitles. (with my sample streams)

-- Frank