[mythtv] [mythtv-commits] Ticket #1176: Initial "help"

[Chris Pinkham]

> > >  INVALID command 'ÿûÿû', try 'help' for more info
> > 
> > I'm probably going to fix this by filtering the input.  I don't think
> > that I can safely flush the input queue for a new connection to catch

> This is probably putty trying to negotiate terminal parameters:
>   http://www.faqs.org/rfcs/rfc854.html
> You can ignore all of them, which indicates that you will do whatever
> the telnet client is expecting you to be doing.

Yeah, this is what Robert and I were discussing on IRC.  I thought
that the telnet spec said the client was supposed to wait for the
server to send a message before the client should try to negotiate
telnet options, but maybe I'm wrong.  Or maybe putty just tries to
negotiate anyway.  Either way, it's still good to filter the input
to a set of valid characters.

I wrote a telnet client/terminal emulator for DOS about 11 years ago
for a client so I know about the handshaking.  The program used the
telnet protocol to connect to a UnixWare server and emulated a Wyse
color terminal so the users could run WordPerfect v5.1 for SCO Unix
under UnixWare and it looked just like they were running WP v5.1
local on their DOS machines (only much faster considering they had
808x or 80286 chips and the UnixWare server was running something
that was brand-spanking new called something goofy like "Pentium"
with the floating point bug and all).  Found a copy of the software
on a floppy disk the other day while cleaning out some old stuff.

Anyway, I could only allow things that match isPunct(), isSpace(),
isLetterOrNumber(), or isSymbol(), but I'm wondering if just
isPrint() would be good enough.  I should get something tested and
in tonight I think.

-- 
Chris