[mythtv] [mythtv-commits] mythtv commit: r8801 by danielk

[Isaac Richards]

On Tuesday 31 January 2006 13:02, Daniel Kristjansson wrote:
> On Tue, 2006-01-31 at 12:44 -0500, Isaac Richards wrote:
> > On Tuesday 31 January 2006 11:30, mythtv at cvs.mythtv.org wrote:
> > >       Author: danielk
> > >         Date: 2006-01-31 16:30:09 +0000 (Tue, 31 Jan 2006)
> > > New Revision: 8801
> > >    Changeset: http://cvs.mythtv.org/trac/changeset/8801
> > >
> > > Modified:
> > >
> > >    trunk/mythtv/libs/libmythtv/ivtvdecoder.cpp
> > >    trunk/mythtv/libs/libmythtv/ivtvdecoder.h
> > >
> > > Log:
> > >
> > > Fixes #1156.
> > >
> > >  * Checks "PVR350OutputEnable" before returning cached value in
> > > CheckDevice. * Changes caching so that it check each device presented
> > > individually, instead of assuming there is only one PVR-350 being used
> > > for output.
> > >
> > > This second change also allows you to change the PVR350VideoDev setting
> > > and have it be checked even if the first device you used worked. Of
> > > course, the caching can fail if you run another program using PVR350
> > > output while MythTV is running, or if you rmmod drivers while MythTV is
> > > running...
> >
> > And it'll break if you try to decode a non-mpeg file, too.
>
> How so? It has always worked for me. The problem with #1156 was just
> that you had to exit the frontend after changing the PVR-350 setting
> for it to take effect. XVideo out is used IvtvDecoder::CanHandle()
> returns false, which it does if AVInputFormat returns anything other
> than "mpeg".

Durr, I'm dumb.  I was confusing CheckDevice and CanHandle.

Isaac