[mythtv] [mythtv-commits] Ticket #1992: Warning fixes
Stuart Auchterlonie
stuarta at squashedfrog.net
Mon Jun 26 21:40:51 UTC 2006
On Mon, Jun 26, 2006 at 06:01:35PM -0000, MythTV wrote:
> #1992: Warning fixes
> -------------------------------+--------------------------------------------
> Reporter: mythtv at remars.com | Owner: danielk
> Type: patch | Status: new
> Priority: trivial | Milestone: 0.20
> Component: mythtv | Version: head
> Severity: low | Resolution:
> -------------------------------+--------------------------------------------
> Comment (by mythtv at remars.com):
>
> The second patch works for me, but disabling such warnings is dangerous !
> I don't think the gcc guys added this warning just for the fun. It may be
> ok to ignore them in this case (pure interface), but in other places we
> should expect destructors to not be called... and we won't have warnings
> to remind us any more.
> Adding the virtual destructors just forces subclasses to have virtual
> destructors, gcc is happy, and we can still be warned when necessary.
>
Since trac is playing silly bugger's i'll email this to -dev for everyone
to look at...
--
I'd vote for fixing the destructors. Here's some info from those who
deal in reliable C++ coding
http://www.codingstandard.com/HICPPCM/Section_3.3_Class_Inheritance.html
and in particular
http://www.codingstandard.com/HICPPCM/Rule_3.3.2.html
--
Stuart
More information about the mythtv-dev
mailing list