[mythtv] Backend SEGV

Marcus Metzler mocm at mocm.de
Wed Mar 1 14:54:39 UTC 2006


>>>>> "Daniel" == Daniel Kristjansson <danielk at cuymedia.net> writes:

    Daniel> On Wed, 2006-03-01 at 15:24 +0100, Marcus Metzler wrote:
    >> >>>>> "Marcus" == Marcus Metzler <mocm at mocm.de> writes:
    Marcus> Since I only saw your fix after I fixed the problem for
    Marcus> myself and I would have to roll back everything to see if
    Marcus> it works, I would like to suggest to add the following
    Marcus> diff to mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp.
    Marcus> This adds some checks to the dvb_decode_text function that
    Marcus> would avoid segfaults. To see that there might be trouble
    Marcus> in other function some warning messages could be added
    Marcus> instead of just returning N/A.
    Daniel> Thanks, but I already fixed the segfault itself in SVN by
    Daniel> applying a modified version of the caching patch from
    Daniel> janne (#1420).

    >> I also would like to mention, that the use of swab is not a
    >> good idea if you want to run myth on systems that are not
    >> little-endian. Since
    Daniel> I agree, I'll fix that shortly.

    Daniel> I think your swab replacement has an off-by-one error
    Daniel> though.

Yes, it is of by one, sorry.

Marcus

-- 
/--------------------------------------------------------------------\
| Dr. Marcus O.C. Metzler        |                                   |
| mocm at metzlerbros.de            | http://www.metzlerbros.de/        |
\--------------------------------------------------------------------/
 |>>>             Quis custodiet ipsos custodes                 <<<|


More information about the mythtv-dev mailing list