[mythtv] [mythtv-commits] Ticket #1315: Move Bookmarks & Cutlist to Recordedmarkup

Stuart Morgan stuart at tase.co.uk
Thu Mar 9 08:49:13 UTC 2006


On Thursday 09 March 2006 04:07, Chris Pinkham wrote:
> Unfortunately it's more than this.  I'm working on a fix now.
> The patch also used toInt() in a couple places below where it should have
> used toString() and toDateTime().  I think that Stuart attached the wrong
> version to the ticket and I didn't test it enough before committing.  I
> verified the bookmark conversion worked but didn't delve deep into the
> cutlist area where this bug occurred.

I'm extremely sorry for this. Chris is mostly right that the dbcheck portion 
of the patch was not the right version. I had been juggling different 
versions of the patch and missed the regression to the broken (copy/pasted) 
code.

My schema had already been updated so I missed it in testing too.

Promise to do better next time, assuming Chris will ever apply any more of my 
patches again :P
-- 
Stuart Morgan


More information about the mythtv-dev mailing list