[mythtv] [mythtv-commits] Ticket #1569: mythvideo grab-bag 'o crunchy goodness

[Michael T. Dean]

On 03/22/2006 04:24 PM, MythTV wrote:
> #1569: mythvideo grab-bag 'o crunchy goodness
>
>  5: allow multiple videos to have the same title
>
>     not an issue for me but recently somebody on -users or -dev
>     mentioned how two videos with the same name will stomp over each
>     other during sorting and I happened to be in the neighbourhood
>     so...
>   

Isn't that significantly more complex (and resource-intensive) than the 
fix in http://svn.mythtv.org/trac/ticket/1354 ?  You're using the same 
hack, only your approach needlessly scans the list a ton of times.

Also (please correct me if I'm wrong, devs), IMHO, posting these changes 
as separate patches (and probably in separate tickets) would make things 
easier for the devs as they could accept some while rejecting others.  
(Patches that rely on other patches could be posted in the same ticket 
as their prerequisites.)

Separate patches would also make it easier for a dev to notice that one 
of the patches attempts to fix a problem that was addressed in another 
patch on an open ticket in Trac (especially if you would have posted 
your patch to the ticket that described the issue).

And, ad added consequence of multiple patches is that they would also 
likely significantly decrease the amount of time required to get the 
patches accepted.  Reviewing a patch that makes a small change (and, 
therefore, has a smaller possibility of unintended side-effects) is 
significantly easier than reviewing a 373-line patch that touches 8 
files, adds 5 new features, and fixes 2 issues.  So, creating 7 
patches--each corresponding to one of your bullet points--would likely 
benefit everyone (devs and users).

Mike