[mythtv] [mythtv-commits] Ticket #1569: mythvideo grab-bag 'o crunchy goodness

[George Nassas]

On 25-Mar-06, at 3:01 PM, Michael T. Dean wrote:

>>  5: allow multiple videos to have the same title
>
> Isn't that significantly more complex (and resource-intensive) than 
> the fix in http://svn.mythtv.org/trac/ticket/1354 ?  You're using the 
> same hack, only your approach needlessly scans the list a ton of 
> times.

Ah yes, the "files with square brackets" in the title made me think he 
was fixing an issue with files that have square brackets so I didn't 
review the patch.

I added this change late in the cycle and didn't notice any slowdown. 
If my puny 1GHz almost-but-not-quite-a-pentium epia can tear through 
that loop in no time then there isn't a problem for other machines.

What I was thinking with appending "+" characters is it keeps the sort 
order deterministic based on where the video appears in the filesystem. 
With IDs it depends on when you added each video which seems random 
unless you've got a rainman type memory.

These are hardly major issues but personally I feel applications look 
more professional when they behave in a predictable way.

> posting these changes as separate patches

I thought about that but didn't want to go back to a clean tree and 
recreate each change and incrementally diff so the options were one big 
patch or a hand edit of the diff into smaller ones. Hand editing has 
obvious opportunities for mistakes so I attached the whole thing. I 
figured if the committer was overwhelmed they'd speak up and I'd either 
annotate the diff or just explain whatever part they were unsure about.

- George