[mythtv] [mythtv-commits] Ticket #1849: [9996] breaks audiowhenusing time stretching

[Mark Spieth]

>
> On Tue, 23 May 2006, Daniel Kristjansson wrote:
>
>> On Wed, 2006-05-24 at 12:55 +1000, Mark Spieth wrote:
>> > > On Wed, 2006-05-24 at 09:06 +1000, Mark Spieth wrote:
>> > > The reason I asked about passthru was because of the change in
>> > > SoundTouch::putSamples(). That change is intended to get rid of
>> > this is not true. it is only going to help if you use the rate 
>> > transposer.
>> > rate is samplerate not tempo change.
>> > I'd put that bit back in. what he was trying to solve is the case where 
>> > the
>> > rate was >1.0 since the rate transposer is used differently than the 
>> > other
>> > case.
>>
>> I'll wait to hear back from Cougar, I'd rather stay in sync with the
>> upstream, unless this really is the problem.
>>
>> Cougar, please try reverting the code in putSamples() to see if that
>> cures your problem.
>
> OK, I reverted SoundTouch.cpp
> (http://cvs.mythtv.org/trac/changeset/9995/trunk/mythtv/libs/libmythsoundtouch/SoundTouch.cpp?format=diff&new=9995&old=9996&new_path=trunk%2Fmythtv%2Flibs%2Flibmythsoundtouch%2FSoundTouch.cpp&old_path=trunk%2Fmythtv%2Flibs%2Flibmythsoundtouch%2FSoundTouch.cpp)
> and it worked again like before.
>
> Btw, the distortion was similar with big overapmifying or something like
> you just cut down highest bit. Is there any easy way to record it (I
> think, using ALSA it is possible)
>
good to know. you didnt need to revert the whole file. :) just uncomment the 
commented out bit in putSamples.
daniel, there may be some fixes for AAFilter (FIR) mmx code which improves 
the rateconverter FIR.
IMO the excluded bit in putSamples should still be reincluded due to CPU 
usage issues.

mark

mark