[mythtv] [mythtv-commits] Ticket #1849:[9996] breaks audiowhenusing time stretching

Mark Spieth mark at dclabs.com.au
Wed May 24 12:56:05 UTC 2006


>> also note the dangling else after the comment close. not that it affects
>> function.
> Yeah, ugly. But since those earlier if's always exit the function
> on truth... Anyway, this also reminds me we should do something
> about those throws at some point.
yes. dont like throws. however since they only catch serious errors in 
config I wouldnt worry about them.
the only one that could conceivably happen is the one in 
FIFOSampleBuffer.cpp

>
>> havent check this thoroughly yet but the ratetransposer at 1.0 seems do 
>> some
>> things when it shouldnt and thus use more cpu.
> The CPU usage is no more than when it's at <1.0, right?
should be the same yes. but why do multiple buffering as a minimum if not 
needed.
note we dont use ratetransposer part ever. thats what libmythsamplerate is 
for.
bit of a waste to pass data through it.

Note I fixed a memalloc issue in the multichannel patch which previously 
wasnt handled correctly (I think).
this used to cause clicks on activation due to no initialization. this may 
be the clicks he was trying to fix.
see TDStretch::acceptNewOverlapLength and related midBuffer new/delete's

mark 



More information about the mythtv-dev mailing list