[mythtv] Why allow conflicting bindings (was Re: "New" default keybindings)
roo.watt at gmail.com
Wed Apr 25 05:15:07 UTC 2007
On 25/04/07, Michael T. Dean <mtdean at thirdcontact.com> wrote:
> So, there's really no reason to prevent a developer's chosen "default"
> mapping for a keybinding from creating a new conflict? That means
> that--since RegisterKey() is only called by REG_KEY(), which is only
> used with string literals--modifying RegisterKey() to check for
> conflicts and ignore the keylist in the event of a conflict would be a
> good thing?
I think this would be a good idea, in the added PLAY keybinding for example,
there was an obvious default binding (PLAY and PAUSE from TV contexts) but
it wasn't used as to avoid possible conflicts. The consequence of this is
that anyone that updates doesn't get the PLAY binding unless they know it
was added and map it themselves. (This neglects the behaviour that your
later changeset implemented).
A user updating might miss the duplicate keybinding log message (as
discussed previously) and it got me thinking (always dangerous).
What if there was a new type of log message (NOTIFICATION or something), it
could not only be written through to the log file but maybe shown under the
"System Status" screen in a new page and used for user notifications.
Maybe it could be used by REG_KEY() when adding a new keybinding, eg "Music
context has new binding PLAY, it is mapped to P" or "Music context has new
binding PLAY, it is not mapped yet due to conflict with default binding".
Just my 2c, spend it how you like. ;)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mythtv-dev