[mythtv] [mythtv-commits] Ticket #3788: instead of deleting a show, mark it for auto-expire and put in a "deleted" group
roo.watt at gmail.com
Fri Aug 3 10:24:53 UTC 2007
On 03/08/07, Chris Pinkham <cpinkham at bc2va.org> wrote:
> kLiveTVAutoExpire const to an enum also probably. My thinking is that
> if you explicitly say to delete a program, you want it to expire before
> other unwatched programs that may auto-expire because of disk space issues.
Absolutely agree, deleted programs should not cause a recording
autoexpire, when it wouldn't have otherwise.
> When you undelete, you should reset the autoexpire value on the
> recording to whatever the default for that recording was (based on
> recordid), but I wonder if you should just force autoeexpire to 0 in
> this case. If I'm undeleting something, I probably don't want it to
> be auto-expired. That may be too much assumption though.
It seems the autoexpire is an int(11) but is currently only using
values >= 0, maybe we could extend the autoexpire / delayed delete to
make use of the full range.
autoexpire > 0: Auto expire recording with (autoexpire) priority
autoexpire = 0: Disable auto expire / delayed delete
autoexpire < 0: Delayed delete with the abs(autoexpire) priority
When deleting a recording the steps are:
1/ Move recording to "Deleted" group
2/ autoexpire *= -1
3/ delete programs with highest abs(autoexpire) priority first
When undeleting a recording the steps are:
1/ Move recording out of "Deleted" group
2/ autoexpire *= -1 (restores original autoexpire value)
3/ autoexpire as per normal
IIRC, there has been some discussion about allowing the user to set an
integer autoexpire value in the recording rule. Using the negative
range as above would work with these change, if someone made them.
More information about the mythtv-dev