[mythtv] [mythtv-commits] Ticket #3522: Deleting a video doesn't delete the .png in the data directory

Michael T. Dean mtdean at thirdcontact.com
Thu Aug 9 07:54:10 UTC 2007


On 08/09/2007 03:21 AM, Nick Morrott wrote:
> On 09/08/07, Michael T. Dean <mtdean at thirdcontact.com> wrote:
>   
>> On 08/08/2007 11:57 PM, MythTV wrote:
>>     
>>> #3522: Deleting a video doesn't delete the .png in the data directory
>>>
>>>
>>> Comment(by Nick Morrott <<knowledgejunkie [at] gmail [dot] com>>):
>>>
>>>  Running r14147, I noticed today that after running mythrename.pl on my
>>>  recordings to be able to readily identify them, deleting them once they
>>>  had been pulled off the box failed to delete any of the thumbnails, but
>>>  did delete the recording.
>>>
>>>  Before renaming the files, I've not noticed any big problems with the
>>>  thumbnails being automatically deleted. I have occasionally found stranded
>>>  thumbnails, but haven't checked into it further.
>>>       
>> Did the PNG's have the old name still?  If so, see
>> http://svn.mythtv.org/trac/ticket/3779 .
>>     
>
> No. This was after new thumbnails had been created using the new
> recorded.basename value after I had manually deleted the old
> thumbnails which had not been renamed. I refreshed the recorded
> programs page in MythWeb and the new files were created. I then
> deleted the files via MythWeb, and the thumbnails were left behind. I
> shall try and test this more with your new patch in place to avoid
> having to have the thumbnails regenerated.

UTF or some kind of special characters in the filenames?

In theory, they should all be deleted.  See
programs/mythbackend/mainserver.cpp around line 1534, specifically:

    QDir      dir  ( fInfo.dirPath(), fInfo.fileName() + "*.png" );

So, the only way I could see them sticking around is a) if there's
something "wrong" with the filename or b) if the PNG's happened to be in
the wrong directory (i.e. you moved the recordings--which Storage Groups
allows--and forgot to move the PNG's, so others may have been created in
the new directory and were properly deleted, leaving the old PNG's in
the old directory).  Since you ran mythrename.pl (and renamed the files
instead of using links), either is possible.

Mike


More information about the mythtv-dev mailing list