[mythtv] [mythtv-commits] mythtv commit: r14224 by nigel

Nigel Pearson nigel at ind.tansu.com.au
Sun Aug 19 22:52:49 UTC 2007


> Shouldn't these GetSetting()s have a second arg string for
> the default when there is no row in the 'settings' table?

They could, but these values are read from mysql.txt only.
The practice seems to be only use defaults when settings
come from mythconverg.settings (and even then not always).


I think the reason for this was so that "default"
values are not written out into the text file,
which makes the file a little smaller/simpler.
(but, given the huge comments that WriteSettingsFile()
  puts in that file, that side-effect is probably negated?)

--
Nigel Pearson, nigel at ind.tansu.com.au|     "They did the
Telstra Net. Eng., Sydney, Australia | white man power dance,
Office: 9202 3900    Fax:  9261 3912 |     and ... Shazam"
Mobile: 0408 664435  Home: 9792 6998 | Lois Lane - Smallville


More information about the mythtv-dev mailing list