[mythtv] [mythtv-commits] Ticket #4263: Svn 15037 -- Compile error osdtypes.cpp: In member function 'QString

[Daniel Kristjansson]

On Mon, 2007-12-03 at 21:36 -0800, Anduin Withers wrote:
> The actual changeset is 15030, this looks to be a fribidi vs fribidi2
> problem:
> 
> fribidi vs. fribidi2 (it takes const strings)
>
> I'm not applying the attached patch, it removes some C99isms and uses
> .data() (should work for both, I only have fribidi easily).

The problem was that the ./configure test was checking the pkg-config
version, rather than the fribidi version. i.e. using --version, not
--mod-version. I rewrote this using --atleast-version. But if you
could make your patch work with both fribidi 0.10.x and fribidi 0.19+
I'm sure a lot of people using distro fribidi packages would appreciate
it. Using ifdef's so that it's easy to remove 0.10.x compatibility in a
few years time might be the best option, adding another pkgconfig test
for a 0.10.x define is fairly simple.

-- Daniel